[PATCH] D14569: [SDAG] Introduce a new BITREVERSE node along with a corresponding LLVM intrinsic
hfinkel@anl.gov via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 11 07:41:22 PST 2015
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
We need a few more tests, especially for the generic expansion. PPC (because you should hit the integer promotion logic) and x86 would be good options, and I think it is perfectly reasonable to test the i8, or even i16, expansions completely. Otherwise, LGTM.
In follow-up, we should make sure we optimize bitreverse(bitreverse(x)) -> x.
Repository:
rL LLVM
http://reviews.llvm.org/D14569
More information about the llvm-commits
mailing list