[PATCH] D14511: Emit discriminator for inlined callsites.

[David Blaikie via llvm-commits]

On Tue, Nov 10, 2015 at 3:24 PM, Diego Novillo via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> dnovillo added a comment.
>
> The one thing I don't understand about this patch is why it needs to add a
> new DW_*discriminator flag? But I don't know enough DWARF to decide whether
> using the existing flag is OK or not.
>

The existing DW_*discriminator is for the line table
(DW_LNE_set_discriminator). The new one is for the DIE attribute
DW_AT_discriminator. The line table will only contain an entry for the
inlined code, not the point of the inline call - the only evidence of that
location is in the DIE tree (the inlined_subroutine), not the line table.
So the discriminator needs to go there.


> Also, this is a final codegen issue?  That is, the actual
> AddDiscriminators pass is DTRT?
>
>
> http://reviews.llvm.org/D14511
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151110/0c650e8a/attachment.html>