[PATCH] D14547: [llvm-profdata] Add support for weighted merge of profile data

[Diego Novillo via llvm-commits]

On Tue, Nov 10, 2015 at 5:44 PM, Xinliang David Li <davidxl at google.com>
wrote:

pros:
>
> 1) the weight and file name are always 'together'. Think about a long list
> of files -- having a separate list option make it harder to associate and
> and  can not really skip the default weight of 1, e.g
> -W10,1,1,1,1,1,1,1,1,1,20
> 2) there is no need for an additional option
> 3) the implementation is simpler and requires fewer code.
>
> cons:
> I don't see any real cons -- except that you find it weird -- but why?
>

It conflates two different concepts.  I tend not to find these situations
very appealing.  However, in this case, your advantage #1 is compelling
(the other 2, not so much).

More comments coming up in the code itself.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151110/9134a59a/attachment.html>