[PATCH] D13671: Add -pretty-print option to llvm-symbolizer

[Alexey Samsonov via llvm-commits]

samsonov added inline comments.

================
Comment at: lib/DebugInfo/Symbolize/DIPrinter.cpp:35
@@ -33,1 +34,3 @@
+    StringRef Prefix = (PrintPretty && Inlined) ? " (inlined by) " : "";
+    OS << Prefix.str() + FunctionName + Delimiter.str();
   }
----------------
Please address. I don't think you need `.str` calls, or even extra vars:
  if (PrintPretty && Inlined)
    OS << " (inlined by) ";
  OS << FunctionName;
  OS << (PrintPretty ? " at " : "\n");

================
Comment at: lib/DebugInfo/Symbolize/DIPrinter.cpp:40
@@ -36,2 +39,3 @@
     Filename = kBadString;
-  OS << Filename << ":" << Info.Line << ":" << Info.Column << "\n";
+  OS << Filename << ":" << std::to_string(Info.Line) << ":"
+     << std::to_string(Info.Column) << "\n";
----------------
Do you still need std::to_string calls?


Repository:
  rL LLVM

http://reviews.llvm.org/D13671