[llvm] r252627 - [ThinLTO] Update comment per change in WeakAny handling (NFC)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 10:26:31 PST 2015


Author: tejohnson
Date: Tue Nov 10 12:26:31 2015
New Revision: 252627

URL: http://llvm.org/viewvc/llvm-project?rev=252627&view=rev
Log:
[ThinLTO] Update comment per change in WeakAny handling (NFC)

Modified:
    llvm/trunk/lib/Linker/LinkModules.cpp

Modified: llvm/trunk/lib/Linker/LinkModules.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Linker/LinkModules.cpp?rev=252627&r1=252626&r2=252627&view=diff
==============================================================================
--- llvm/trunk/lib/Linker/LinkModules.cpp (original)
+++ llvm/trunk/lib/Linker/LinkModules.cpp Tue Nov 10 12:26:31 2015
@@ -655,7 +655,9 @@ bool ModuleLinker::doImportAsDefinition(
       return false;
     return doImportAsDefinition(GA->getBaseObject());
   }
-  // Always import GlobalVariable definitions. The linkage changes
+  // Always import GlobalVariable definitions, except for the special
+  // case of WeakAny which are imported as ExternalWeak declarations
+  // (see comments in ModuleLinker::getLinkage). The linkage changes
   // described in ModuleLinker::getLinkage ensure the correct behavior (e.g.
   // global variables with external linkage are transformed to
   // available_externally definitions, which are ultimately turned into




More information about the llvm-commits mailing list