[PATCH] D14513: [CMake] Add support for building the llvm test-suite as part of an LLVM build using clang and lld

[Chris Bieneman via llvm-commits]

beanz added a comment.

So the idea here is `make test-suite` or `ninja test-suite` will work, and if clang or lld change it will do a full re-configure, clean, rebuild.

Updates coming shortly to fix issues.


================
Comment at: cmake/modules/LLVMExternalProjectUtils.cmake:7
@@ +6,3 @@
+  if (CMAKE_GENERATOR MATCHES "Make")
+    # Use special command for Makefiles to support parallelism.
+    set(${out_var} "$(MAKE)" "${target}" PARENT_SCOPE)
----------------
jmolloy wrote:
> Is there a ninja equivalent, do you know?
No, it isn't needed for Ninja. Make fails oddly if two instances try to manipulate the same directory, and this is fixed by invoking make directly from make because the processes will talk to each other.

Ninja has now IPC, and it just doesn't die in odd ways when two instances build on top of each other. 

================
Comment at: cmake/modules/LLVMExternalProjectUtils.cmake:45
@@ +44,3 @@
+  endforeach()
+  if(TARGET compiler-rt AND CLANG_IN_TOOLCHAIN)
+    list(APPEND TOOLCHAIN_BINS compiler-rt)
----------------
jmolloy wrote:
> It's confusing that this is testing CLANG_IN_TOOLCHAIN before it is set. Is this deliberate? if so it could do with some comments.
No, this is a bug. Will fix.

================
Comment at: cmake/modules/LLVMExternalProjectUtils.cmake:77
@@ +76,3 @@
+    COMMAND ${CMAKE_COMMAND} -E remove_directory ${STAMP_DIR}
+    COMMENT "Clobberring ${name} build and stamp directories"
+    ${cmake_3_2_USES_TERMINAL}
----------------
jmolloy wrote:
> Clobbering*
Even with spell check on I can't spell.


http://reviews.llvm.org/D14513