[PATCH] D14356: Sancov in C++.

[Mike Aizatsky via llvm-commits]

aizatsky added a comment.

All done. PTAL.


================
Comment at: lib/sanitizer_common/sancov.cc:163
@@ +162,3 @@
+    }
+    std::sort(Addrs->begin(), Addrs->end());
+    Addrs->erase(std::unique(Addrs->begin(), Addrs->end()), Addrs->end());
----------------
kcc wrote:
> won't it be simpler to insert everything into a set, and they copy into a vector? 
Wouldn't that be slower?

================
Comment at: lib/sanitizer_common/sancov.cc:217
@@ +216,3 @@
+        uint32_t Line = FrameInfo.Line;
+        std::string FunctionName = demangle(FrameInfo.FunctionName);
+
----------------
kcc wrote:
> not necessary in this change, but we'll need an option for demangling, similar to "-functions" option of llvm-symbolizer 
> 
why do we need not-demangled output?


http://reviews.llvm.org/D14356