[PATCH] D14150: Pointers in Masked Load, Store, Gather, Scatter intrinsics.

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 10 07:15:55 PST 2015


delena added inline comments.

================
Comment at: ../lib/IR/Function.cpp:495
@@ -494,1 +494,3 @@
     Result += "f"; 
+  } else if (isa<VectorType>(Ty) &&
+             isa<PointerType>(Ty->getVectorElementType())) {
----------------
mkuper wrote:
> Perhaps it's worth handling all vectors here, instead of checking for PointerType?
> Or does the potential discrepancy with getEVTString() for MVT vector types break something?
Yes, getEVTString() works only for simple types. I changed the patch and invoked the recursion for all vectors. In this case the mangled string will be composed for vector of functions, vector of structures, vector of vectors .. 


Repository:
  rL LLVM

http://reviews.llvm.org/D14150





More information about the llvm-commits mailing list