[PATCH] D14398: Strip metadata when speculatively hoisting instructions

[Igor Laevsky via llvm-commits]

igor-laevsky added inline comments.

================
Comment at: lib/Transforms/Scalar/LICM.cpp:675
@@ -674,1 +674,3 @@
 
+  // Metadata can be dependant on the condition we are hoisting above.
+  // Conservativelly strip all metadata on the instruction.
----------------
sanjoy wrote:
> This is clearly a step in the right direction.
> 
> However, I think we can be more precise than this:  (unless I'm missing something) if we justified hoisting the operation using `isGuaranteedToExecute` and not via `isSafeToSpeculativelyExecute`, I think we can keep the metadata.  Perhaps something like that could be done in a separate patch?
I think you are right. I'll probably try to come up with something about this.


Repository:
  rL LLVM

http://reviews.llvm.org/D14398