[PATCH] D14356: Sancov in C++.

[Kostya Serebryany via llvm-commits]

kcc added inline comments.

================
Comment at: lib/sanitizer_common/sancov.cc:192
@@ +191,3 @@
+  // Line format: <file_name>:<line> <function_name>
+  void printCoveredFns(raw_ostream &out) {
+    if (Addrs->empty())
----------------
printCoveredFunctions

================
Comment at: lib/sanitizer_common/sancov.cc:217
@@ +216,3 @@
+        uint32_t Line = FrameInfo.Line;
+        std::string FunctionName = demangle(FrameInfo.FunctionName);
+
----------------
not necessary in this change, but we'll need an option for demangling, similar to "-functions" option of llvm-symbolizer 


================
Comment at: lib/sanitizer_common/sancov.cc:226
@@ +225,3 @@
+    std::string FilePrefix = Fns.begin()->first.FileName;
+    for (const auto &P : Fns) {
+      FilePrefix = CommonPrefix(FilePrefix, P.first.FileName);
----------------
no {}

================
Comment at: lib/sanitizer_common/sancov.cc:244
@@ +243,3 @@
+
+        if (ProcessedFunctions.find(FunctionName) != ProcessedFunctions.end()) {
+          continue;
----------------
no {} 


http://reviews.llvm.org/D14356