[PATCH] D14361: Let SelectionDAG start to use probability-based interface to add successors.

[Manman Ren via llvm-commits]

manmanren added a comment.

In http://reviews.llvm.org/D14361#285380, @congh wrote:

> In http://reviews.llvm.org/D14361#284529, @manmanren wrote:
>
> > It seems that we can submit the changes other than SelectionDAGBuilder.h, SelectionDAGBuilder.cpp and SelectionDAGISel.cpp, separately. Correct me if I am wrong.
> >
> > Thanks for working on this!
> > Manman
>
>
> Changes under lib/Target/ should be checked in with SelectionDAG* as they are all doing instruction lowering. Other changes are for them so I think we need to put them together.


I am kind of confused. It seems to me that this change only sets up Probs array in MachineBasicBlock, but it does not start using it. When looking for getProbabilityIterator or getSuccProbability, I can't find any usage.

If we commit the change in lib/Target/X86/X86FrameLowering.cpp, we will be calling the new interface addSuccor(..., BranchProb), that will set up both Probs and Weights array in MachineBasicBlock, MBPI will still be using the Weights array, everything should just work, right?

I may have missed some obvious things :)

Cheers,
Manman


http://reviews.llvm.org/D14361