[PATCH] D14511: Emit discriminator for inlined callsites.

[David Blaikie via llvm-commits]

btw, there's no need to file a bug as you're providing a fix - feel free to
skip the overhead and just provide the patch & skip the bug

The only real reason to file a bug in the open source tracker is if you
want someone else to look at/work on it/know you are working on it before
you've sent out a patch, etc.

On Mon, Nov 9, 2015 at 1:15 PM, David Blaikie via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> dblaikie added inline comments.
>
> ================
> Comment at: test/DebugInfo/Generic/discriminator.ll:11
> @@ +10,3 @@
> +;
> +;static void bar() { abc(); }
> +;static void baz() { xyz(); }
> ----------------
> perhaps write these with __attribute__((always_inline)) so you can build
> the example without running the full optimization pipeline & still get the
> desired code.
>
> Do you need two different inline functions or two different destination
> functions? (maybe it makes the example simpler/more obvious, which is fair
> - but it could just be two of the same)
>
> ================
> Comment at: test/DebugInfo/Generic/discriminator.ll:14
> @@ +13,3 @@
> +;
> +;void foo(int i) {
> +;  bar(); baz();
> ----------------
> I assume this function doesn't need a parameter
>
>
> http://reviews.llvm.org/D14511
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151109/2bd047c8/attachment.html>