[PATCH] D14454: [WinEH] Fix mutli-parent cloning
Joseph Tremoulet via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 9 11:13:34 PST 2015
JosephTremoulet added a comment.
Looks good to me.
> change the BlockColors value type (container) from a std::set to a SetVector. I don't think that should be a problem given the expected size of the sets involved
I agree. It's maybe too bad we don't have a SmallSetVector that just uses a vector when small like a SmallSet but allows deterministic iteration when large like a SetVector. (not trying to suggest you stop to add such a thing for this lone use case, just thinking "out loud"...)
Repository:
rL LLVM
http://reviews.llvm.org/D14454
More information about the llvm-commits
mailing list