[PATCH] D14140: [ELF2] SECTIONS command basic support

[Rui Ueyama via llvm-commits]

ruiu added a comment.

One question is the performance with this patch. Does this slow down the linker? If so, how much?


================
Comment at: ELF/Writer.cpp:935
@@ -901,1 +934,3 @@
 
+template <class ELFT> void Writer<ELFT>::parseSectionDescriptions() {
+  for (const std::pair<StringRef, std::vector<StringRef>> &OutSec :
----------------
Can you avoid using a word "parse" here? Linker scripts are and should be parsed by LinkerScript.cpp, so every time I see this name, it feels like a domain error. I don't have a good suggestion, but I'd probably name createSectionMap or something.


http://reviews.llvm.org/D14140