[PATCH] D14495: [X86] Do not try to custom-lower sitofp/fptosi in soft-float mode

Mitch Bodart via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 10:45:17 PST 2015


mbodart added a comment.

The changes look good, but I have a couple questions on the requirements of soft float support.

Is soft float expected to work for f80?  If so, can you please add some test cases?

The test only covers 32-bit targets.  Is it expected to work for x86_64?

Minor comment on the test function names.
While it's unlikely to be problematic in the context of this test,
note that "l" and "ul" are substrings of "ll" and "ull", and could
inadvertently match where unintended.  Names like u32 and s64
would fix that.


http://reviews.llvm.org/D14495





More information about the llvm-commits mailing list