[PATCH] D13382: GlobalOpt should maintain externally_initialized when splitting aggregates

[Oliver Stannard via llvm-commits]

Ah, sorry, my mistake. I see it in the mail thread, but not in Phab.

I don’t think there’s any need for further review.

From: James Molloy [mailto:james at jamesmolloy.co.uk]
Sent: 09 November 2015 16:36
To: Oliver Stannard; reviews+D13382+public+b1749bb76d44e9b5 at reviews.llvm.org; tra at google.com; richard at metafoo.co.uk
Cc: llvm-commits at lists.llvm.org
Subject: Re: [PATCH] D13382: GlobalOpt should maintain externally_initialized when splitting aggregates

I did LGTM this one specifically - I see it in the same mail thread.

I felt the behaviour was obvious and shouldn't depend on ObjC selector support - it looks correct according to LangRef.

However if you want someone else to chip in I'm not going to stand in your way :)

James

On Mon, 9 Nov 2015 at 16:33 Oliver Stannard <oliver.stannard at arm.com<mailto:oliver.stannard at arm.com>> wrote:
You LGTM’d a related patch (D13343), I had assumed that you did not review this one because of the CUDA and Objective-C questions (in the phabricator summary).

Oliver

From: James Molloy [mailto:james at jamesmolloy.co.uk<mailto:james at jamesmolloy.co.uk>]
Sent: 09 November 2015 16:27
To: reviews+D13382+public+b1749bb76d44e9b5 at reviews.llvm.org<mailto:reviews%2BD13382%2Bpublic%2Bb1749bb76d44e9b5 at reviews.llvm.org>; Oliver Stannard; tra at google.com<mailto:tra at google.com>; richard at metafoo.co.uk<mailto:richard at metafoo.co.uk>
Cc: llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
Subject: Re: [PATCH] D13382: GlobalOpt should maintain externally_initialized when splitting aggregates

Hi Oliver,

I did LGTM this on the 19th October. Did you want more reviews?
James

On Mon, 9 Nov 2015 at 16:22 Oliver Stannard via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
olista01 added reviewers: tra, rsmith.
olista01 added a comment.

Ping? (and adding some reviewers that may be able to answer the question about CUDA and Objective-C)


Repository:
  rL LLVM

http://reviews.llvm.org/D13382



_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

________________________________

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151109/44d47bee/attachment.html>