[PATCH] D14313: Add a libLTO diagnostic handler that supports lto_get_error_message API

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a comment.

I think all that you need is the change to the constructor call of IRLinker and the current change in tools/* no?


================
Comment at: lib/LTO/LTOCodeGenerator.cpp:79
@@ -70,1 +78,3 @@
+    return "";
+  }
 }
----------------
The switch is already fully covered, no?

================
Comment at: lib/LTO/LTOCodeGenerator.cpp:83
@@ +82,3 @@
+                                const char *Msg, void *) {
+  errs() << getLTODiagnosticPrefix(Severity) << Msg << "\n";
+}
----------------
Since this is code in lib/, it would probably better to not set the diagonstic handler at all.


http://reviews.llvm.org/D14313