[PATCH] D14150: Pointers in Masked Load, Store, Gather, Scatter intrinsics.

[Michael Kuperstein via llvm-commits]

mkuper added a comment.

Hi Elena,

A few comments inline.


================
Comment at: ../docs/LangRef.rst:11266
@@ -11265,3 +11265,3 @@
 """""""
-This is an overloaded intrinsic. The loaded data is a vector of any integer or floating point data type.
+This is an overloaded intrinsic. The loaded data is a vector of any integer or floating point data type. The loaded data may also be a vector of pointers.
 
----------------
Can we make this one sentence? "The loaded data is a vector of any integer, floating point, or pointer data type", perhaps?

================
Comment at: ../docs/LangRef.rst:11311
@@ -11306,3 +11310,3 @@
 """""""
-This is an overloaded intrinsic. The data stored in memory is a vector of any integer or floating point data type.
+This is an overloaded intrinsic. The data stored in memory is a vector of any integer or floating point data type. The stored data may also be a vector of pointers.
 
----------------
Same as above.

================
Comment at: ../lib/IR/Function.cpp:495
@@ -494,1 +494,3 @@
     Result += "f"; 
+  } else if (isa<VectorType>(Ty) &&
+             isa<PointerType>(Ty->getVectorElementType())) {
----------------
Perhaps it's worth handling all vectors here, instead of checking for PointerType?
Or does the potential discrepancy with getEVTString() for MVT vector types break something?


Repository:
  rL LLVM

http://reviews.llvm.org/D14150