[PATCH] D14464: Add discriminators for call instructions that are from the same line and same basic block.

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 05:47:12 PST 2015


dnovillo accepted this revision.
dnovillo added a comment.
This revision is now accepted and ready to land.

LGTM with a minor documentation fix.


================
Comment at: lib/Transforms/Utils/AddDiscriminators.cpp:229
@@ +228,3 @@
+  // Traverse all instructions and assign new discriminators to call
+  // instructions with the same lineno that are in the same basic block.
+  for (BasicBlock &B : F) {
----------------
Add some explanation here as to why this is important for SamplePGO?  Thanks.


http://reviews.llvm.org/D14464





More information about the llvm-commits mailing list