[PATCH] D12856: Always promote f16

Oliver Stannard via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 03:06:58 PST 2015


olista01 added a comment.

Thanks, committed revision 252459 with the suggested changes.


================
Comment at: test/CodeGen/ARM/fp16-promote.ll:885-886
@@ -897,5 +884,4 @@
 
 ; CHECK-ALL-LABEL: test_struct_arg:
-; CHECK-ALL-NEXT: .fnstart
-; CHECK-ALL-NEXT: bx lr
+; CHECK-ALL: bx lr
 define half @test_struct_arg(%struct.dummy %p) {
----------------
ab wrote:
> Did we start emitting anything else? If not, I'd keep the -NEXT and .fnstart.
Yes, we emit a mov here because the soft-float calling convention is different. I'll update the test to make this explicit.


Repository:
  rL LLVM

http://reviews.llvm.org/D12856





More information about the llvm-commits mailing list