[PATCH] D14474: Also map the personality function in CloneFunctionInto

[David Majnemer via llvm-commits]

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: lib/IR/Verifier.cpp:1761
@@ +1760,3 @@
+  if (F.hasPersonalityFn()) {
+    Function *Per =
+        dyn_cast<Function>(F.getPersonalityFn()->stripPointerCasts());
----------------
`auto *Per`

================
Comment at: lib/Transforms/Utils/CloneFunction.cpp:98
@@ -97,1 +97,3 @@
 
+  // Fix up the personality function that got copied over
+  if (NewFunc->hasPersonalityFn())
----------------
Please end this sentence in a period.

================
Comment at: lib/Transforms/Utils/CloneFunction.cpp:99
@@ +98,3 @@
+  // Fix up the personality function that got copied over
+  if (NewFunc->hasPersonalityFn())
+    NewFunc->setPersonalityFn(
----------------
Shouldn't this be `OldFunc->hasPersonalityFn()`?


Repository:
  rL LLVM

http://reviews.llvm.org/D14474