[llvm] r252373 - Revert "ADT: Require explicit ilist iterator/pointer conversions"

[Duncan P. N. Exon Smith via llvm-commits]

> On 2015-Nov-06, at 16:09, Duncan P. N. Exon Smith via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: dexonsmith
> Date: Fri Nov  6 18:09:14 2015
> New Revision: 252373
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=252373&view=rev
> Log:
> Revert "ADT: Require explicit ilist iterator/pointer conversions"
> 
> This reverts commit r252372.  Apparently I missed clang-tools-extra.
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/2534/steps/build/logs/stdio

I can't read errors well.  Here was the error.
--
/home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.src/examples/Fibonacci/fibonacci.cpp:55:13: error: no viable conversion from 'arg_iterator' (aka 'ilist_iterator<llvm::Argument>') to 'llvm::Argument *'
  Argument *ArgX = FibF->arg_begin();   // Get the arg.
            ^      ~~~~~~~~~~~~~~~~~
1 error generated.
--

I'll recommit when I can.

> 
> Modified:
>    llvm/trunk/include/llvm/ADT/ilist.h
> 
> Modified: llvm/trunk/include/llvm/ADT/ilist.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/ilist.h?rev=252373&r1=252372&r2=252373&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/ADT/ilist.h (original)
> +++ llvm/trunk/include/llvm/ADT/ilist.h Fri Nov  6 18:09:14 2015
> @@ -220,8 +220,8 @@ private:
>   template<class T> void operator-(T) const;
> public:
> 
> -  explicit ilist_iterator(pointer NP) : NodePtr(NP) {}
> -  explicit ilist_iterator(reference NR) : NodePtr(&NR) {}
> +  ilist_iterator(pointer NP) : NodePtr(NP) {}
> +  ilist_iterator(reference NR) : NodePtr(&NR) {}
>   ilist_iterator() : NodePtr(nullptr) {}
> 
>   // This is templated so that we can allow constructing a const iterator from
> @@ -241,7 +241,7 @@ public:
>   void reset(pointer NP) { NodePtr = NP; }
> 
>   // Accessors...
> -  explicit operator pointer() const {
> +  operator pointer() const {
>     return NodePtr;
>   }
> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits