[PATCH] D14346: Reduce size of MCRelaxableFragment

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 13:35:36 PST 2015


rafael added a comment.

Can you please first commit a change just ading the getSti() and rebase? It should make this patch a lot easier to read.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:239
@@ -239,1 +238,3 @@
+    EmitInlineAsm(M.getModuleInlineAsm()+"\n",
+                  OutContext.getSubtargetCopy(*STI), TM.Options.MCOptions);
     OutStreamer->AddComment("End of file scope inline assembly");
----------------
Why do you need this copy? The idea is that we create a copy every time we toggle a bit during parsing, no? If so, this should not need a copy.



http://reviews.llvm.org/D14346





More information about the llvm-commits mailing list