[PATCH] D12781: PGO IR-level instrumentation infrastructure

[David Li via llvm-commits]

davidxl added inline comments.

================
Comment at: include/llvm/Support/CFGMST.h:1
@@ +1,2 @@
+//===- CFGMST.cpp - Minimum Spanning Tree for CFG --------===//
+//
----------------
CFGMST.h.

================
Comment at: include/llvm/Support/CFGMST.h:29
@@ +28,3 @@
+
+#define DEBUG_TYPE "cfgmst"
+
----------------
It  seems that this class is still not general enough to be put into llvm/Support/ directory, I suggest move this file back to PGO directory for now.

A more general implementation should also support MachineBB. Also what interfaces need to be exposed, and what template parameters are needed, do we really need to expose edge at interface level (for this class, instead just use a pair of BBs to query on-tree status?) do we need to pass in opaque edge info types (which only clients know about) etc are all open questions -- this is the reason I don't think it is ready to be put into Support. Add a TODO for future work there.

More comments will follow later.


http://reviews.llvm.org/D12781