[PATCH] D14450: [ELF2] Add mandatory .dynamic section entries on MIPS.

Fri Nov 6 11:38:55 PST 2015

ikudrin added inline comments.

================
Comment at: ELF/OutputSections.cpp:491
@@ -480,3 +490,3 @@
     ++NumEntries; // DT_PLTRELSZ
-    ++NumEntries; // DT_PLTGOT
+    ++NumEntries; // DT_PLTGOT or DT_MIPS_PLTGOT
     ++NumEntries; // DT_PLTREL
----------------
ikudrin wrote:
> atanasyan wrote:
> > Do you read MIPS ABI? DT_MIPS_PLTGOT is used in the non-PIC MIPS code only. PIC MIPS code uses DT_PLTGOT entry but this entry points to the .got section.
> The logic of this line: if we have .plt.got section, then store its address to DT_MIPS_PLTGOT entry. Is something wrong here?
> Please note, the DT_PLTGOT entry for MIPS target is mentioned a bit later in this function.
Moreover, the logic here is the same as in this patch for the old lld: http://reviews.llvm.org/rL200630.


http://reviews.llvm.org/D14450



