[PATCH] D14449: [ELF2] -omagic implementation

[Davide Italiano via llvm-commits]

On Fri, Nov 6, 2015 at 11:21 AM, George Rimar <grimar at accesssoftek.com> wrote:
>>От: davide.italiano at gmail.com [davide.italiano at gmail.com] от имени Davide Italiano [davide at freebsd.org]
>>Отправлено: 6 ноября 2015 г. 20:10
>>Кому: George Rimar; reviews+D14449+public+d5b6896f0026b788 at reviews.llvm.org
>>Копия: Rafael Ávila de Espíndola; Rui Ueyama; llvm-commits at lists.llvm.org
>>Тема: Re: [PATCH] D14449: [ELF2] -omagic implementation
>>
>>Is somebody really using this?
>
> Well, it could be used is for -r patch (relocatable output) which status is still unclear. Its description mentions that "As a side effect, in environments that support standard Unix magic numbers, this option also sets the output file’s magic number to "OMAGIC"".
> Second possible use (I guessing here) is for writing self modifiying apps.

It's fine if it's used for -r, assuming we need it. That said, this is
just my opinion, but I'd like to not support an option just for the
sake of doing it -- i.e. unless there's not somebody consuming it. GNU
ld.bfd is a complex beast that includes weird options for some very
specific use cases that may not be of any usefulness for the general
audience. Not saying that this patch belongs to the category but we
should be really careful about what we do support and what we don't.

My $0.02,

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare