[PATCH] D14387: Move comdat setup after global value body linking in ModuleLinker

[Teresa Johnson via llvm-commits]

On Fri, Nov 6, 2015 at 11:20 AM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
>> Can you change metadata linking *not* to cause the def to be linked in?
>> The debug info *shouldn't* be causing anything to be linked in that isn't
>> already (since debug info should not affect code generation).  Instead,
>> you can just have the `variable:` field point at nullptr.
>
> +1
>
> Adding metadata should not change what non-metadata IR is linked in
> (even declarations).
>
> Cheers,
> Rafael

That's what I ended up doing (in the new metadata linking patch D14447
which I recommitted earlier this morning). Hopefully it will stick
this time!

Thanks,
Teresa



-- 
Teresa Johnson | Software Engineer | tejohnson at google.com | 408-460-2413