[llvm] r252192 - Reapply r250906 with many suggested updates from Rafael Espindola.
Pasi Parviainen via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 6 00:23:04 PST 2015
On 5.11.2015 21:24, Kevin Enderby via llvm-commits wrote:
> Author: enderby
> Date: Thu Nov 5 13:24:56 2015
> New Revision: 252192
>
> URL: http://llvm.org/viewvc/llvm-project?rev=252192&view=rev
> Log:
> Reapply r250906 with many suggested updates from Rafael Espindola.
> The needed lld matching changes to be submitted immediately next,
> but this revision will cause lld failures with this alone which is expected.
>
> This removes the eating of the error in Archive::Child::getSize() when the characters
> in the size field in the archive header for the member is not a number. To do this we
> have all of the needed methods return ErrorOr to push them up until we get out of lib.
> Then the tools and can handle the error in whatever way is appropriate for that tool.
>
> So the solution is to plumb all the ErrorOr stuff through everything that touches archives.
> This include its iterators as one can create an Archive object but the first or any other
> Child object may fail to be created due to a bad size field in its header.
>
> Thanks to Lang Hames on the changes making child_iterator contain an
> ErrorOr<Child> instead of a Child and the needed changes to ErrorOr.h to add
> operator overloading for * and -> .
>
> We don’t want to use llvm_unreachable() as it calls abort() and is produces a “crash”
> and using report_fatal_error() to move the error checking will cause the program to
> stop, neither of which are really correct in library code. There are still some uses of
> these that should be cleaned up in this library code for other than the size field.
>
> The test cases use archives with text files so one can see the non-digit character,
> in this case a ‘%’, in the size field.
>
> These changes will require corresponding changes to the lld project. That will be
> committed immediately after this change. But this revision will cause lld failures
> with this alone which is expected.
>
> Added:
> llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus1.a
> llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus2.a
> llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus3.a
> llvm/trunk/test/tools/llvm-objdump/malformed-archives.test
> Modified:
> llvm/trunk/include/llvm/Object/Archive.h
> llvm/trunk/include/llvm/Support/ErrorOr.h
> llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp
> llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h
> llvm/trunk/lib/Object/Archive.cpp
> llvm/trunk/lib/Object/ArchiveWriter.cpp
> llvm/trunk/tools/dsymutil/BinaryHolder.cpp
> llvm/trunk/tools/llvm-ar/llvm-ar.cpp
> llvm/trunk/tools/llvm-cxxdump/llvm-cxxdump.cpp
> llvm/trunk/tools/llvm-nm/llvm-nm.cpp
> llvm/trunk/tools/llvm-objdump/MachODump.cpp
> llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
> llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp
> llvm/trunk/tools/llvm-size/llvm-size.cpp
>
> Modified: llvm/trunk/include/llvm/Object/Archive.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/Archive.h?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Object/Archive.h (original)
> +++ llvm/trunk/include/llvm/Object/Archive.h Thu Nov 5 13:24:56 2015
> @@ -66,7 +66,7 @@ public:
> bool isThinMember() const;
>
> public:
> - Child(const Archive *Parent, const char *Start);
> + Child(const Archive *Parent, const char *Start, std::error_code *EC);
> Child(const Archive *Parent, StringRef Data, uint16_t StartOfFile);
>
> bool operator ==(const Child &other) const {
> @@ -75,7 +75,7 @@ public:
> }
>
> const Archive *getParent() const { return Parent; }
> - Child getNext() const;
> + ErrorOr<Child> getNext() const;
>
> ErrorOr<StringRef> getName() const;
> StringRef getRawName() const { return getHeader()->getName(); }
> @@ -91,9 +91,9 @@ public:
> return getHeader()->getAccessMode();
> }
> /// \return the size of the archive member without the header or padding.
> - uint64_t getSize() const;
> + ErrorOr<uint64_t> getSize() const;
> /// \return the size in the archive header for this member.
> - uint64_t getRawSize() const;
> + ErrorOr<uint64_t> getRawSize() const;
>
> ErrorOr<StringRef> getBuffer() const;
> uint64_t getChildOffset() const;
> @@ -105,24 +105,32 @@ public:
> };
>
> class child_iterator {
> - Child child;
> + ErrorOr<Child> child;
>
> public:
> - child_iterator() : child(Child(nullptr, nullptr)) {}
> + child_iterator() : child(Child(nullptr, nullptr, nullptr)) {}
> child_iterator(const Child &c) : child(c) {}
> - const Child *operator->() const { return &child; }
> - const Child &operator*() const { return child; }
> + child_iterator(std::error_code EC) : child(EC) {}
> + const ErrorOr<Child> *operator->() const { return &child; }
> + const ErrorOr<Child> &operator*() const { return child; }
>
> bool operator==(const child_iterator &other) const {
> - return child == other.child;
> + // We ignore error states so that comparisions with end() work, which
> + // allows range loops.
> + if (child.getError() || other.child.getError())
> + return false;
> + return *child == *other.child;
> }
>
> bool operator!=(const child_iterator &other) const {
> return !(*this == other);
> }
>
> + // Code in loops with child_iterators must check for errors on each loop
> + // iteration. And if there is an error break out of the loop.
> child_iterator &operator++() { // Preincrement
> - child = child.getNext();
> + assert(child && "Can't increment iterator with error");
> + child = child->getNext();
> return *this;
> }
> };
>
> Modified: llvm/trunk/include/llvm/Support/ErrorOr.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/ErrorOr.h?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/ErrorOr.h (original)
> +++ llvm/trunk/include/llvm/Support/ErrorOr.h Thu Nov 5 13:24:56 2015
> @@ -91,6 +91,7 @@ private:
> typedef typename std::remove_reference<T>::type &reference;
> typedef const typename std::remove_reference<T>::type &const_reference;
> typedef typename std::remove_reference<T>::type *pointer;
> + typedef const typename std::remove_reference<T>::type *const_pointer;
>
> public:
> template <class E>
> @@ -183,10 +184,14 @@ public:
> return toPointer(getStorage());
> }
>
> + const_pointer operator->() const { return toPointer(getStorage()); }
> +
> reference operator *() {
> return *getStorage();
> }
>
> + const_reference operator*() const { return *getStorage(); }
> +
> private:
> template <class OtherT>
> void copyConstruct(const ErrorOr<OtherT> &Other) {
> @@ -246,10 +251,14 @@ private:
> return Val;
> }
>
> + const_pointer toPointer(const_pointer Val) const { return Val; }
> +
> pointer toPointer(wrap *Val) {
> return &Val->get();
> }
>
> + const_pointer toPointer(const wrap *Val) const { return &Val->get(); }
> +
> storage_type *getStorage() {
> assert(!HasError && "Cannot get value when an error exists!");
> return reinterpret_cast<storage_type*>(TStorage.buffer);
>
> Modified: llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp (original)
> +++ llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.cpp Thu Nov 5 13:24:56 2015
> @@ -318,10 +318,12 @@ RuntimeDyld::SymbolInfo MCJIT::findSymbo
> object::Archive *A = OB.getBinary();
> // Look for our symbols in each Archive
> object::Archive::child_iterator ChildIt = A->findSym(Name);
> + if (std::error_code EC = ChildIt->getError())
> + report_fatal_error(EC.message());
> if (ChildIt != A->child_end()) {
> // FIXME: Support nested archives?
> ErrorOr<std::unique_ptr<object::Binary>> ChildBinOrErr =
> - ChildIt->getAsBinary();
> + (*ChildIt)->getAsBinary();
> if (ChildBinOrErr.getError())
> continue;
> std::unique_ptr<object::Binary> &ChildBin = ChildBinOrErr.get();
>
> Modified: llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h (original)
> +++ llvm/trunk/lib/ExecutionEngine/Orc/OrcMCJITReplacement.h Thu Nov 5 13:24:56 2015
> @@ -252,10 +252,12 @@ private:
> object::Archive *A = OB.getBinary();
> // Look for our symbols in each Archive
> object::Archive::child_iterator ChildIt = A->findSym(Name);
> + if (std::error_code EC = ChildIt->getError())
> + report_fatal_error(EC.message());
> if (ChildIt != A->child_end()) {
> // FIXME: Support nested archives?
> ErrorOr<std::unique_ptr<object::Binary>> ChildBinOrErr =
> - ChildIt->getAsBinary();
> + (*ChildIt)->getAsBinary();
> if (ChildBinOrErr.getError())
> continue;
> std::unique_ptr<object::Binary> &ChildBin = ChildBinOrErr.get();
>
> Modified: llvm/trunk/lib/Object/Archive.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/Archive.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Object/Archive.cpp (original)
> +++ llvm/trunk/lib/Object/Archive.cpp Thu Nov 5 13:24:56 2015
> @@ -46,7 +46,7 @@ StringRef ArchiveMemberHeader::getName()
> ErrorOr<uint32_t> ArchiveMemberHeader::getSize() const {
> uint32_t Ret;
> if (llvm::StringRef(Size, sizeof(Size)).rtrim(" ").getAsInteger(10, Ret))
> - return object_error::parse_failed;
> + return object_error::parse_failed; // Size is not a decimal number.
> return Ret;
> }
>
> @@ -86,7 +86,8 @@ Archive::Child::Child(const Archive *Par
> uint16_t StartOfFile)
> : Parent(Parent), Data(Data), StartOfFile(StartOfFile) {}
>
> -Archive::Child::Child(const Archive *Parent, const char *Start)
> +Archive::Child::Child(const Archive *Parent, const char *Start,
> + std::error_code *EC)
> : Parent(Parent) {
> if (!Start)
> return;
> @@ -94,7 +95,10 @@ Archive::Child::Child(const Archive *Par
> uint64_t Size = sizeof(ArchiveMemberHeader);
> Data = StringRef(Start, Size);
> if (!isThinMember()) {
> - Size += getRawSize();
> + ErrorOr<uint64_t> MemberSize = getRawSize();
> + if ((*EC = MemberSize.getError()))
> + return;
lld-link is crashing here since matching changes to lld in r252193.
Crash is caused by passing nullptr as EC argument. If nullptr is valid
value for EC then this check should be more like:
if (!MemberSize) {
if (EC)
*EC = MemberSize.getError();
return;
}
Pasi
> + Size += MemberSize.get();
> Data = StringRef(Start, Size);
> }
>
> @@ -110,20 +114,20 @@ Archive::Child::Child(const Archive *Par
> }
> }
>
> -uint64_t Archive::Child::getSize() const {
> +ErrorOr<uint64_t> Archive::Child::getSize() const {
> if (Parent->IsThin) {
> ErrorOr<uint32_t> Size = getHeader()->getSize();
> - if (Size.getError())
> - return 0;
> + if (std::error_code EC = Size.getError())
> + return EC;
> return Size.get();
> }
> return Data.size() - StartOfFile;
> }
>
> -uint64_t Archive::Child::getRawSize() const {
> +ErrorOr<uint64_t> Archive::Child::getRawSize() const {
> ErrorOr<uint32_t> Size = getHeader()->getSize();
> - if (Size.getError())
> - return 0;
> + if (std::error_code EC = Size.getError())
> + return EC;
> return Size.get();
> }
>
> @@ -133,8 +137,12 @@ bool Archive::Child::isThinMember() cons
> }
>
> ErrorOr<StringRef> Archive::Child::getBuffer() const {
> - if (!isThinMember())
> - return StringRef(Data.data() + StartOfFile, getSize());
> + if (!isThinMember()) {
> + ErrorOr<uint32_t> Size = getSize();
> + if (std::error_code EC = Size.getError())
> + return EC;
> + return StringRef(Data.data() + StartOfFile, Size.get());
> + }
> ErrorOr<StringRef> Name = getName();
> if (std::error_code EC = Name.getError())
> return EC;
> @@ -148,7 +156,7 @@ ErrorOr<StringRef> Archive::Child::getBu
> return Parent->ThinBuffers.back()->getBuffer();
> }
>
> -Archive::Child Archive::Child::getNext() const {
> +ErrorOr<Archive::Child> Archive::Child::getNext() const {
> size_t SpaceToSkip = Data.size();
> // If it's odd, add 1 to make it even.
> if (SpaceToSkip & 1)
> @@ -156,11 +164,19 @@ Archive::Child Archive::Child::getNext()
>
> const char *NextLoc = Data.data() + SpaceToSkip;
>
> + // Check to see if this is at the end of the archive.
> + if (NextLoc == Parent->Data.getBufferEnd())
> + return Child(Parent, nullptr, nullptr);
> +
> // Check to see if this is past the end of the archive.
> - if (NextLoc >= Parent->Data.getBufferEnd())
> - return Child(Parent, nullptr);
> + if (NextLoc > Parent->Data.getBufferEnd())
> + return object_error::parse_failed;
>
> - return Child(Parent, NextLoc);
> + std::error_code EC;
> + Child Ret(Parent, NextLoc, &EC);
> + if (EC)
> + return EC;
> + return Ret;
> }
>
> uint64_t Archive::Child::getChildOffset() const {
> @@ -255,15 +271,26 @@ Archive::Archive(MemoryBufferRef Source,
> }
>
> // Get the special members.
> - child_iterator i = child_begin(false);
> - child_iterator e = child_end();
> + child_iterator I = child_begin(false);
> + if ((ec = I->getError()))
> + return;
> + child_iterator E = child_end();
>
> - if (i == e) {
> + if (I == E) {
> ec = std::error_code();
> return;
> }
> + const Child *C = &**I;
> +
> + auto Increment = [&]() {
> + ++I;
> + if ((ec = I->getError()))
> + return true;
> + C = &**I;
> + return false;
> + };
>
> - StringRef Name = i->getRawName();
> + StringRef Name = C->getRawName();
>
> // Below is the pattern that is used to figure out the archive format
> // GNU archive format
> @@ -288,9 +315,11 @@ Archive::Archive(MemoryBufferRef Source,
> Format = K_BSD;
> // We know that the symbol table is not an external file, so we just assert
> // there is no error.
> - SymbolTable = *i->getBuffer();
> - ++i;
> - setFirstRegular(*i);
> + SymbolTable = *C->getBuffer();
> + if (Increment())
> + return;
> + setFirstRegular(*C);
> +
> ec = std::error_code();
> return;
> }
> @@ -298,7 +327,7 @@ Archive::Archive(MemoryBufferRef Source,
> if (Name.startswith("#1/")) {
> Format = K_BSD;
> // We know this is BSD, so getName will work since there is no string table.
> - ErrorOr<StringRef> NameOrErr = i->getName();
> + ErrorOr<StringRef> NameOrErr = C->getName();
> ec = NameOrErr.getError();
> if (ec)
> return;
> @@ -306,10 +335,11 @@ Archive::Archive(MemoryBufferRef Source,
> if (Name == "__.SYMDEF SORTED" || Name == "__.SYMDEF") {
> // We know that the symbol table is not an external file, so we just
> // assert there is no error.
> - SymbolTable = *i->getBuffer();
> - ++i;
> + SymbolTable = *C->getBuffer();
> + if (Increment())
> + return;
> }
> - setFirstRegular(*i);
> + setFirstRegular(*C);
> return;
> }
>
> @@ -322,32 +352,34 @@ Archive::Archive(MemoryBufferRef Source,
> if (Name == "/" || Name == "/SYM64/") {
> // We know that the symbol table is not an external file, so we just assert
> // there is no error.
> - SymbolTable = *i->getBuffer();
> + SymbolTable = *C->getBuffer();
> if (Name == "/SYM64/")
> has64SymTable = true;
>
> - ++i;
> - if (i == e) {
> + if (Increment())
> + return;
> + if (I == E) {
> ec = std::error_code();
> return;
> }
> - Name = i->getRawName();
> + Name = C->getRawName();
> }
>
> if (Name == "//") {
> Format = has64SymTable ? K_MIPS64 : K_GNU;
> // The string table is never an external member, so we just assert on the
> // ErrorOr.
> - StringTable = *i->getBuffer();
> - ++i;
> - setFirstRegular(*i);
> + StringTable = *C->getBuffer();
> + if (Increment())
> + return;
> + setFirstRegular(*C);
> ec = std::error_code();
> return;
> }
>
> if (Name[0] != '/') {
> Format = has64SymTable ? K_MIPS64 : K_GNU;
> - setFirstRegular(*i);
> + setFirstRegular(*C);
> ec = std::error_code();
> return;
> }
> @@ -360,25 +392,28 @@ Archive::Archive(MemoryBufferRef Source,
> Format = K_COFF;
> // We know that the symbol table is not an external file, so we just assert
> // there is no error.
> - SymbolTable = *i->getBuffer();
> + SymbolTable = *C->getBuffer();
> +
> + if (Increment())
> + return;
>
> - ++i;
> - if (i == e) {
> - setFirstRegular(*i);
> + if (I == E) {
> + setFirstRegular(*C);
> ec = std::error_code();
> return;
> }
>
> - Name = i->getRawName();
> + Name = C->getRawName();
>
> if (Name == "//") {
> // The string table is never an external member, so we just assert on the
> // ErrorOr.
> - StringTable = *i->getBuffer();
> - ++i;
> + StringTable = *C->getBuffer();
> + if (Increment())
> + return;
> }
>
> - setFirstRegular(*i);
> + setFirstRegular(*C);
> ec = std::error_code();
> }
>
> @@ -390,12 +425,15 @@ Archive::child_iterator Archive::child_b
> return Child(this, FirstRegularData, FirstRegularStartOfFile);
>
> const char *Loc = Data.getBufferStart() + strlen(Magic);
> - Child c(this, Loc);
> - return c;
> + std::error_code EC;
> + Child c(this, Loc, &EC);
> + if (EC)
> + return child_iterator(EC);
> + return child_iterator(c);
> }
>
> Archive::child_iterator Archive::child_end() const {
> - return Child(this, nullptr);
> + return Child(this, nullptr, nullptr);
> }
>
> StringRef Archive::Symbol::getName() const {
> @@ -447,7 +485,11 @@ ErrorOr<Archive::Child> Archive::Symbol:
> }
>
> const char *Loc = Parent->getData().begin() + Offset;
> - return Child(Parent, Loc);
> + std::error_code EC;
> + Child C(Parent, Loc, &EC);
> + if (EC)
> + return EC;
> + return C;
> }
>
> Archive::Symbol Archive::Symbol::getNext() const {
>
> Modified: llvm/trunk/lib/Object/ArchiveWriter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ArchiveWriter.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Object/ArchiveWriter.cpp (original)
> +++ llvm/trunk/lib/Object/ArchiveWriter.cpp Thu Nov 5 13:24:56 2015
> @@ -39,7 +39,7 @@ NewArchiveIterator::NewArchiveIterator(c
> : IsNewMember(false), Name(Name), OldMember(OldMember) {}
>
> NewArchiveIterator::NewArchiveIterator(StringRef FileName)
> - : IsNewMember(true), Name(FileName), OldMember(nullptr, nullptr) {}
> + : IsNewMember(true), Name(FileName), OldMember(nullptr, nullptr, nullptr) {}
>
> StringRef NewArchiveIterator::getName() const { return Name; }
>
> @@ -412,8 +412,11 @@ llvm::writeArchive(StringRef ArcName,
> Status.getSize());
> } else {
> const object::Archive::Child &OldMember = I.getOld();
> + ErrorOr<uint32_t> Size = OldMember.getSize();
> + if (std::error_code EC = Size.getError())
> + return std::make_pair("", EC);
> printMemberHeader(Out, Kind, Thin, I.getName(), StringMapIndexIter,
> - ModTime, UID, GID, Perms, OldMember.getSize());
> + ModTime, UID, GID, Perms, Size.get());
> }
>
> if (!Thin)
>
> Added: llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus1.a
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus1.a?rev=252192&view=auto
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus1.a (added)
> +++ llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus1.a Thu Nov 5 13:24:56 2015
> @@ -0,0 +1,13 @@
> +!<arch>
> +hello.c 1444941273 124 0 100644 10% `
> +#include <stdio.h>
> +#include <stdlib.h>
> +int
> +main()
> +{
> + printf("Hello World\n");
> + return EXIT_SUCCESS;
> +}
> +foo.c 1444941645 124 0 100644 1% `
> +void foo(void){}
> +
>
> Added: llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus2.a
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus2.a?rev=252192&view=auto
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus2.a (added)
> +++ llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus2.a Thu Nov 5 13:24:56 2015
> @@ -0,0 +1,13 @@
> +!<arch>
> +hello.c 1444941273 124 0 100644 102 `
> +#include <stdio.h>
> +#include <stdlib.h>
> +int
> +main()
> +{
> + printf("Hello World\n");
> + return EXIT_SUCCESS;
> +}
> +foo.c 1444941645 124 0 100644 1% `
> +void foo(void){}
> +
>
> Added: llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus3.a
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus3.a?rev=252192&view=auto
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus3.a (added)
> +++ llvm/trunk/test/tools/llvm-objdump/Inputs/libbogus3.a Thu Nov 5 13:24:56 2015
> @@ -0,0 +1,16 @@
> +!<arch>
> +hello.c 1444941273 124 0 100644 102 `
> +#include <stdio.h>
> +#include <stdlib.h>
> +int
> +main()
> +{
> + printf("Hello World\n");
> + return EXIT_SUCCESS;
> +}
> +foo.c 1444941645 124 0 100644 171 `
> +void foo(void){}
> +
> +bar.c 1445026190 124 0 100644 17 `
> +void foo(void){}
> +
>
> Added: llvm/trunk/test/tools/llvm-objdump/malformed-archives.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/malformed-archives.test?rev=252192&view=auto
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-objdump/malformed-archives.test (added)
> +++ llvm/trunk/test/tools/llvm-objdump/malformed-archives.test Thu Nov 5 13:24:56 2015
> @@ -0,0 +1,20 @@
> +// These test checks that llvm-objdump will not crash with malformed Archive
> +// files. So the check line is not all that important but the bug fixes to
> +// make sure llvm-objdump is robust is what matters.
> +# RUN: llvm-objdump -macho -archive-headers \
> +# RUN: %p/Inputs/libbogus1.a \
> +# RUN: 2>&1 | FileCheck -check-prefix=bogus1 %s
> +
> +# bogus1: Invalid data was encountered while parsing the file
> +
> +# RUN: not llvm-objdump -macho -archive-headers \
> +# RUN: %p/Inputs/libbogus2.a \
> +# RUN: 2>&1 | FileCheck -check-prefix=bogus2 %s
> +
> +# bogus2: LLVM ERROR: Invalid data was encountered while parsing the file
> +
> +# RUN: not llvm-objdump -macho -archive-headers \
> +# RUN: %p/Inputs/libbogus3.a \
> +# RUN: 2>&1 | FileCheck -check-prefix=bogus3 %s
> +
> +# bogus3: LLVM ERROR: Invalid data was encountered while parsing the file
>
> Modified: llvm/trunk/tools/dsymutil/BinaryHolder.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/BinaryHolder.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/tools/dsymutil/BinaryHolder.cpp (original)
> +++ llvm/trunk/tools/dsymutil/BinaryHolder.cpp Thu Nov 5 13:24:56 2015
> @@ -109,7 +109,10 @@ BinaryHolder::GetArchiveMemberBuffers(St
> Buffers.reserve(CurrentArchives.size());
>
> for (const auto &CurrentArchive : CurrentArchives) {
> - for (const auto &Child : CurrentArchive->children()) {
> + for (auto ChildOrErr : CurrentArchive->children()) {
> + if (std::error_code Err = ChildOrErr.getError())
> + return Err;
> + const auto &Child = *ChildOrErr;
> if (auto NameOrErr = Child.getName()) {
> if (*NameOrErr == Filename) {
> if (Timestamp != sys::TimeValue::PosixZeroTime() &&
>
> Modified: llvm/trunk/tools/llvm-ar/llvm-ar.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-ar/llvm-ar.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-ar/llvm-ar.cpp (original)
> +++ llvm/trunk/tools/llvm-ar/llvm-ar.cpp Thu Nov 5 13:24:56 2015
> @@ -338,7 +338,9 @@ static void doDisplayTable(StringRef Nam
> printMode(Mode & 007);
> outs() << ' ' << C.getUID();
> outs() << '/' << C.getGID();
> - outs() << ' ' << format("%6llu", C.getSize());
> + ErrorOr<uint64_t> Size = C.getSize();
> + failIfError(Size.getError());
> + outs() << ' ' << format("%6llu", Size.get());
> outs() << ' ' << C.getLastModified().str();
> outs() << ' ';
> }
> @@ -403,7 +405,10 @@ static void performReadOperation(Archive
> }
>
> bool Filter = !Members.empty();
> - for (const object::Archive::Child &C : OldArchive->children()) {
> + for (auto &ChildOrErr : OldArchive->children()) {
> + failIfError(ChildOrErr.getError());
> + const object::Archive::Child &C = *ChildOrErr;
> +
> ErrorOr<StringRef> NameOrErr = C.getName();
> failIfError(NameOrErr.getError());
> StringRef Name = NameOrErr.get();
> @@ -523,7 +528,9 @@ computeNewArchiveMembers(ArchiveOperatio
> int InsertPos = -1;
> StringRef PosName = sys::path::filename(RelPos);
> if (OldArchive) {
> - for (auto &Child : OldArchive->children()) {
> + for (auto &ChildOrErr : OldArchive->children()) {
> + failIfError(ChildOrErr.getError());
> + auto &Child = ChildOrErr.get();
> int Pos = Ret.size();
> ErrorOr<StringRef> NameOrErr = Child.getName();
> failIfError(NameOrErr.getError());
> @@ -726,7 +733,9 @@ static void runMRIScript() {
> failIfError(LibOrErr.getError(), "Could not parse library");
> Archives.push_back(std::move(*LibOrErr));
> object::Archive &Lib = *Archives.back();
> - for (auto &Member : Lib.children()) {
> + for (auto &MemberOrErr : Lib.children()) {
> + failIfError(MemberOrErr.getError());
> + auto &Member = MemberOrErr.get();
> ErrorOr<StringRef> NameOrErr = Member.getName();
> failIfError(NameOrErr.getError());
> addMember(NewMembers, Member, *NameOrErr);
>
> Modified: llvm/trunk/tools/llvm-cxxdump/llvm-cxxdump.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cxxdump/llvm-cxxdump.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-cxxdump/llvm-cxxdump.cpp (original)
> +++ llvm/trunk/tools/llvm-cxxdump/llvm-cxxdump.cpp Thu Nov 5 13:24:56 2015
> @@ -482,7 +482,9 @@ static void dumpCXXData(const ObjectFile
> }
>
> static void dumpArchive(const Archive *Arc) {
> - for (const Archive::Child &ArcC : Arc->children()) {
> + for (auto &ErrorOrChild : Arc->children()) {
> + error(ErrorOrChild.getError());
> + const Archive::Child &ArcC = *ErrorOrChild;
> ErrorOr<std::unique_ptr<Binary>> ChildOrErr = ArcC.getAsBinary();
> if (std::error_code EC = ChildOrErr.getError()) {
> // Ignore non-object files.
>
> Modified: llvm/trunk/tools/llvm-nm/llvm-nm.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-nm/llvm-nm.cpp (original)
> +++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp Thu Nov 5 13:24:56 2015
> @@ -967,7 +967,10 @@ static void dumpSymbolNamesFromFile(std:
>
> for (Archive::child_iterator I = A->child_begin(), E = A->child_end();
> I != E; ++I) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr = I->getAsBinary(&Context);
> + if (error(I->getError()))
> + return;
> + auto &C = I->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = C.getAsBinary(&Context);
> if (ChildOrErr.getError())
> continue;
> if (SymbolicFile *O = dyn_cast<SymbolicFile>(&*ChildOrErr.get())) {
> @@ -1022,8 +1025,11 @@ static void dumpSymbolNamesFromFile(std:
> for (Archive::child_iterator AI = A->child_begin(),
> AE = A->child_end();
> AI != AE; ++AI) {
> + if (error(AI->getError()))
> + return;
> + auto &C = AI->get();
> ErrorOr<std::unique_ptr<Binary>> ChildOrErr =
> - AI->getAsBinary(&Context);
> + C.getAsBinary(&Context);
> if (ChildOrErr.getError())
> continue;
> if (SymbolicFile *O =
> @@ -1076,8 +1082,11 @@ static void dumpSymbolNamesFromFile(std:
> for (Archive::child_iterator AI = A->child_begin(),
> AE = A->child_end();
> AI != AE; ++AI) {
> + if (error(AI->getError()))
> + return;
> + auto &C = AI->get();
> ErrorOr<std::unique_ptr<Binary>> ChildOrErr =
> - AI->getAsBinary(&Context);
> + C.getAsBinary(&Context);
> if (ChildOrErr.getError())
> continue;
> if (SymbolicFile *O =
> @@ -1125,8 +1134,10 @@ static void dumpSymbolNamesFromFile(std:
> std::unique_ptr<Archive> &A = *AOrErr;
> for (Archive::child_iterator AI = A->child_begin(), AE = A->child_end();
> AI != AE; ++AI) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr =
> - AI->getAsBinary(&Context);
> + if (error(AI->getError()))
> + return;
> + auto &C = AI->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = C.getAsBinary(&Context);
> if (ChildOrErr.getError())
> continue;
> if (SymbolicFile *O = dyn_cast<SymbolicFile>(&*ChildOrErr.get())) {
>
> Modified: llvm/trunk/tools/llvm-objdump/MachODump.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/MachODump.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-objdump/MachODump.cpp (original)
> +++ llvm/trunk/tools/llvm-objdump/MachODump.cpp Thu Nov 5 13:24:56 2015
> @@ -1417,8 +1417,10 @@ static void printArchiveChild(const Arch
> outs() << format("%3d/", UID);
> unsigned GID = C.getGID();
> outs() << format("%-3d ", GID);
> - uint64_t Size = C.getRawSize();
> - outs() << format("%5" PRId64, Size) << " ";
> + ErrorOr<uint64_t> Size = C.getRawSize();
> + if (std::error_code EC = Size.getError())
> + report_fatal_error(EC.message());
> + outs() << format("%5" PRId64, Size.get()) << " ";
>
> StringRef RawLastModified = C.getRawLastModified();
> if (verbose) {
> @@ -1454,7 +1456,9 @@ static void printArchiveChild(const Arch
> static void printArchiveHeaders(Archive *A, bool verbose, bool print_offset) {
> for (Archive::child_iterator I = A->child_begin(false), E = A->child_end();
> I != E; ++I) {
> - Archive::Child C = *I;
> + if (std::error_code EC = I->getError())
> + report_fatal_error(EC.message());
> + const Archive::Child &C = **I;
> printArchiveChild(C, verbose, print_offset);
> }
> }
> @@ -1491,7 +1495,13 @@ void llvm::ParseInputMachO(StringRef Fil
> printArchiveHeaders(A, !NonVerbose, ArchiveMemberOffsets);
> for (Archive::child_iterator I = A->child_begin(), E = A->child_end();
> I != E; ++I) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr = I->getAsBinary();
> + if (std::error_code EC = I->getError()) {
> + errs() << "llvm-objdump: '" << Filename << "': " << EC.message()
> + << ".\n";
> + exit(1);
> + }
> + auto &C = I->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = C.getAsBinary();
> if (ChildOrErr.getError())
> continue;
> if (MachOObjectFile *O = dyn_cast<MachOObjectFile>(&*ChildOrErr.get())) {
> @@ -1539,7 +1549,13 @@ void llvm::ParseInputMachO(StringRef Fil
> for (Archive::child_iterator AI = A->child_begin(),
> AE = A->child_end();
> AI != AE; ++AI) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr = AI->getAsBinary();
> + if (std::error_code EC = AI->getError()) {
> + errs() << "llvm-objdump: '" << Filename
> + << "': " << EC.message() << ".\n";
> + exit(1);
> + }
> + auto &C = AI->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = C.getAsBinary();
> if (ChildOrErr.getError())
> continue;
> if (MachOObjectFile *O =
> @@ -1581,7 +1597,13 @@ void llvm::ParseInputMachO(StringRef Fil
> for (Archive::child_iterator AI = A->child_begin(),
> AE = A->child_end();
> AI != AE; ++AI) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr = AI->getAsBinary();
> + if (std::error_code EC = AI->getError()) {
> + errs() << "llvm-objdump: '" << Filename << "': " << EC.message()
> + << ".\n";
> + exit(1);
> + }
> + auto &C = AI->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = C.getAsBinary();
> if (ChildOrErr.getError())
> continue;
> if (MachOObjectFile *O =
> @@ -1617,7 +1639,13 @@ void llvm::ParseInputMachO(StringRef Fil
> printArchiveHeaders(A.get(), !NonVerbose, ArchiveMemberOffsets);
> for (Archive::child_iterator AI = A->child_begin(), AE = A->child_end();
> AI != AE; ++AI) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr = AI->getAsBinary();
> + if (std::error_code EC = AI->getError()) {
> + errs() << "llvm-objdump: '" << Filename << "': " << EC.message()
> + << ".\n";
> + exit(1);
> + }
> + auto &C = AI->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = C.getAsBinary();
> if (ChildOrErr.getError())
> continue;
> if (MachOObjectFile *O =
>
> Modified: llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp (original)
> +++ llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp Thu Nov 5 13:24:56 2015
> @@ -1537,7 +1537,10 @@ static void DumpObject(const ObjectFile
>
> /// @brief Dump each object file in \a a;
> static void DumpArchive(const Archive *a) {
> - for (const Archive::Child &C : a->children()) {
> + for (auto &ErrorOrChild : a->children()) {
> + if (std::error_code EC = ErrorOrChild.getError())
> + report_error(a->getFileName(), EC);
> + const Archive::Child &C = *ErrorOrChild;
> ErrorOr<std::unique_ptr<Binary>> ChildOrErr = C.getAsBinary();
> if (std::error_code EC = ChildOrErr.getError())
> if (EC != object_error::invalid_file_type)
>
> Modified: llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp (original)
> +++ llvm/trunk/tools/llvm-readobj/llvm-readobj.cpp Thu Nov 5 13:24:56 2015
> @@ -377,7 +377,10 @@ static void dumpObject(const ObjectFile
>
> /// @brief Dumps each object file in \a Arc;
> static void dumpArchive(const Archive *Arc) {
> - for (const auto &Child : Arc->children()) {
> + for (auto &ErrorOrChild : Arc->children()) {
> + if (std::error_code EC = ErrorOrChild.getError())
> + reportError(Arc->getFileName(), EC.message());
> + const auto &Child = *ErrorOrChild;
> ErrorOr<std::unique_ptr<Binary>> ChildOrErr = Child.getAsBinary();
> if (std::error_code EC = ChildOrErr.getError()) {
> // Ignore non-object files.
>
> Modified: llvm/trunk/tools/llvm-size/llvm-size.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-size/llvm-size.cpp?rev=252192&r1=252191&r2=252192&view=diff
> ==============================================================================
> --- llvm/trunk/tools/llvm-size/llvm-size.cpp (original)
> +++ llvm/trunk/tools/llvm-size/llvm-size.cpp Thu Nov 5 13:24:56 2015
> @@ -428,7 +428,13 @@ static void PrintFileSectionSizes(String
> for (object::Archive::child_iterator i = a->child_begin(),
> e = a->child_end();
> i != e; ++i) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr = i->getAsBinary();
> + if (i->getError()) {
> + errs() << ToolName << ": " << file << ": " << i->getError().message()
> + << ".\n";
> + exit(1);
> + }
> + auto &c = i->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = c.getAsBinary();
> if (std::error_code EC = ChildOrErr.getError()) {
> errs() << ToolName << ": " << file << ": " << EC.message() << ".\n";
> continue;
> @@ -490,7 +496,13 @@ static void PrintFileSectionSizes(String
> for (object::Archive::child_iterator i = UA->child_begin(),
> e = UA->child_end();
> i != e; ++i) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr = i->getAsBinary();
> + if (std::error_code EC = i->getError()) {
> + errs() << ToolName << ": " << file << ": " << EC.message()
> + << ".\n";
> + exit(1);
> + }
> + auto &c = i->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = c.getAsBinary();
> if (std::error_code EC = ChildOrErr.getError()) {
> errs() << ToolName << ": " << file << ": " << EC.message()
> << ".\n";
> @@ -567,7 +579,13 @@ static void PrintFileSectionSizes(String
> for (object::Archive::child_iterator i = UA->child_begin(),
> e = UA->child_end();
> i != e; ++i) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr = i->getAsBinary();
> + if (std::error_code EC = i->getError()) {
> + errs() << ToolName << ": " << file << ": " << EC.message()
> + << ".\n";
> + exit(1);
> + }
> + auto &c = i->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = c.getAsBinary();
> if (std::error_code EC = ChildOrErr.getError()) {
> errs() << ToolName << ": " << file << ": " << EC.message()
> << ".\n";
> @@ -631,7 +649,12 @@ static void PrintFileSectionSizes(String
> for (object::Archive::child_iterator i = UA->child_begin(),
> e = UA->child_end();
> i != e; ++i) {
> - ErrorOr<std::unique_ptr<Binary>> ChildOrErr = i->getAsBinary();
> + if (std::error_code EC = i->getError()) {
> + errs() << ToolName << ": " << file << ": " << EC.message() << ".\n";
> + exit(1);
> + }
> + auto &c = i->get();
> + ErrorOr<std::unique_ptr<Binary>> ChildOrErr = c.getAsBinary();
> if (std::error_code EC = ChildOrErr.getError()) {
> errs() << ToolName << ": " << file << ": " << EC.message() << ".\n";
> continue;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
More information about the llvm-commits
mailing list