[PATCH] D14394: Moving FileManager::removeDotPaths to llvm::sys::path::remove_dots

[Mike Aizatsky via llvm-commits]

aizatsky added a comment.

> I would probably leave remove_leading_dotslash intact, ant that should eliminate the need to change the test.


I disagree. The old function is much more limited - it stripped "./" only at the beginning. Plus it would result in two very similar functions. I think having only one is better.


================
Comment at: test/Frontend/dependency-gen.c:19
@@ -18,3 +18,3 @@
 // RUN: %clang -MD -MF - %s -fsyntax-only -I a/b/. | FileCheck -check-prefix=CHECK-FIVE %s
-// CHECK-FIVE: {{ }}a/b/.{{[/\\]}}x.h
+// CHECK-FIVE: {{ }}a/b{{[/\\]}}x.h
 // RUN: cd a/b
----------------
kcc wrote:
> This is an intended change, right? Why? 
Because new function also removes /./ in the middle. It used to be a/b/./x.h and it is now a/b/x.h


http://reviews.llvm.org/D14394