[PATCH] D14350: [FunctionAttrs] Fix an iterator wraparound bug

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 13:25:32 PST 2015


sanjoy added a comment.

Actually, I think it will be cleaner to do the same fix I did in http://reviews.llvm.org/D14363 here as well, since we have a direct pointer to the `Use *` here as well.  It won't quite be NFC, since we'll enter the worklist loop multiple times for the same value in cases like

  call void @f(i32* readonly nocapture %x, i32* %x)

so it may slightly regress compile time if the second use of `%x` was a vararg argument.  But I think it will make the code easier to read.


http://reviews.llvm.org/D14350





More information about the llvm-commits mailing list