[PATCH] D14368: [ValueTracking] Add a framework for encoding implication rules

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 12:38:57 PST 2015


majnemer added inline comments.

================
Comment at: lib/Analysis/ValueTracking.cpp:4113
@@ +4112,3 @@
+    // LHS u<  LHS +_{nuw} C   if C > 0
+    // LHS u<= LHS +_{nuw} C   if C >= 0
+    if (match(RHS, m_NUWAdd(m_Specific(LHS), m_ConstantInt(CI)))) {
----------------
Isn't this vacuously true?  I don't think we need to restrict `C` here.


http://reviews.llvm.org/D14368





More information about the llvm-commits mailing list