[lld] r252131 - [elf2] Fix R_X86_64_TPOFF32 handling.

Thu Nov 5 12:30:15 PST 2015

On Nov 5, 2015 3:09 PM, "Michael Spencer via llvm-commits" <
llvm-commits at lists.llvm.org> wrote:
>
> On Thu, Nov 5, 2015 at 11:25 AM, Rui Ueyama <ruiu at google.com> wrote:
> > Took a quick look at gold and found this piece of code.
> >
> >
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gold/x86_64.cc;h=3651d398ff673ab0d56ed8a0211482ccf132ead7;hb=HEAD#l3942
> >
> > This doesn't seems to include the padding.
>
> gold adds the padding to the end of the PT_TLS by aligning p_memsz to
p_align.

That is probably better, no? We can add any padding we want to PT_TLS. In
contrast the current logic might be depending on a glibc implementation
detail.

Cheers, Rafael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151105/b2ad712b/attachment.html>