[PATCH] D14242: [ASan] Enable optional ASan recovery (LLVM core part)

[Yury Gribov via llvm-commits]

ygribov added inline comments.

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:143
@@ +142,3 @@
+        "Enable recovery mode (continue-after-error). "
+        "WARNING: USE AT YOUR OWN RISK!"),
+    cl::Hidden, cl::init(false));
----------------
eugenis wrote:
> I'd remove these WARNINGS here and in the compiler-rt patch too. The whole "ASan" thing is use-at-your-own-risk, and this feature is not that much scarier than the rest.
Ok, although Kostya may disagree here)

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1099
@@ -1083,2 +1098,3 @@
     Value *Cmp2 = createSlowPathCmp(IRB, AddrLong, ShadowValue, TypeSize);
-    BasicBlock *CrashBlock =
+    if (Recover)
+      CrashTerm = SplitBlockAndInsertIfThen(Cmp2, CheckTerm, false);
----------------
eugenis wrote:
> {}
> I think we never do "if" w/o {} followed by "else" with {}.
> 
Sorry, I remember you mentioning this last time.


http://reviews.llvm.org/D14242