[PATCH] D13989: This removes the eating of the error in Archive::Child::getSize() when the charactersin the size field in the archive header for the member is not a number.

Kevin Enderby via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 11:20:51 PST 2015


enderby updated this revision to Diff 39388.
enderby added a comment.

This final patch includes many suggested updates from Rafael Espindola emails.  Rafael's last email contained:

On Nov 5, 2015, at 6:48 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

LGTM with the "exit with 0 on error" issues fixed.


http://reviews.llvm.org/D13989

Files:
  include/llvm/Object/Archive.h
  include/llvm/Support/ErrorOr.h
  lib/ExecutionEngine/MCJIT/MCJIT.cpp
  lib/ExecutionEngine/Orc/OrcMCJITReplacement.h
  lib/Object/Archive.cpp
  lib/Object/ArchiveWriter.cpp
  test/tools/llvm-objdump/Inputs/libbogus1.a
  test/tools/llvm-objdump/Inputs/libbogus2.a
  test/tools/llvm-objdump/Inputs/libbogus3.a
  test/tools/llvm-objdump/malformed-archives.test
  tools/dsymutil/BinaryHolder.cpp
  tools/llvm-ar/llvm-ar.cpp
  tools/llvm-cxxdump/llvm-cxxdump.cpp
  tools/llvm-nm/llvm-nm.cpp
  tools/llvm-objdump/MachODump.cpp
  tools/llvm-objdump/llvm-objdump.cpp
  tools/llvm-readobj/llvm-readobj.cpp
  tools/llvm-size/llvm-size.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13989.39388.patch
Type: text/x-patch
Size: 30759 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151105/79f50f5b/attachment.bin>


More information about the llvm-commits mailing list