[PATCH] D14346: Reduce size of MCRelaxableFragment

[Rafael Espíndola via llvm-commits]

We will get invalid references if SubtargetCopies is reallocated.

You need to keep the index or use an allocator when giving out copies.

What are the memory savings the you get with this patch?

Cheers, Rafael
On Nov 4, 2015 3:16 PM, "Akira Hatanaka via llvm-commits" <
llvm-commits at lists.llvm.org> wrote:

> ahatanak created this revision.
> ahatanak added a subscriber: llvm-commits.
> Herald added subscribers: dsanders, jyknight, arsenm.
>
> This patch replaces the copy of MCSubtargetInfo in MCRelaxableFragment,
> which accounted for nearly 40% of MCRelaxableFragment, with a const
> reference to MCSubtargetInfo to make MCRelaxableFragment smaller.
>
> http://reviews.llvm.org/D14346
>
> Files:
>   include/llvm/MC/MCAssembler.h
>   include/llvm/MC/MCContext.h
>   include/llvm/MC/MCTargetAsmParser.h
>   include/llvm/Support/TargetRegistry.h
>   lib/CodeGen/AsmPrinter/AsmPrinter.cpp
>   lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp
>   lib/MC/MCContext.cpp
>   lib/MC/MCParser/MCTargetAsmParser.cpp
>   lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
>   lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
>   lib/Target/ARM/AsmParser/ARMAsmParser.cpp
>   lib/Target/Mips/AsmParser/MipsAsmParser.cpp
>   lib/Target/PowerPC/AsmParser/PPCAsmParser.cpp
>   lib/Target/Sparc/AsmParser/SparcAsmParser.cpp
>   lib/Target/SystemZ/AsmParser/SystemZAsmParser.cpp
>   lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp
>   lib/Target/X86/AsmParser/X86AsmInstrumentation.h
>   lib/Target/X86/AsmParser/X86AsmParser.cpp
>   utils/TableGen/AsmMatcherEmitter.cpp
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151105/18228e94/attachment.html>