[PATCH] D14288: [tsan] Alternative ThreadState storage for OS X

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 05:12:05 PST 2015


dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM after addition of note to cur_thread_finalize and removal of memset.


================
Comment at: lib/tsan/rtl/tsan_platform_mac.cc:54
@@ +53,3 @@
+    CHECK(val);
+    internal_memset(val, 0, size);
+    void *cmp = nullptr;
----------------
This is unnecessary with mmap, remove.


http://reviews.llvm.org/D14288





More information about the llvm-commits mailing list