[PATCH] D14356: Sancov in C++.

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 21:13:27 PST 2015


silvas added a subscriber: silvas.

================
Comment at: lib/sanitizer_common/sancov.cc:86
@@ +85,3 @@
+
+static bool removeDotPaths(SmallVectorImpl<char> *Path) {
+  using namespace llvm::sys;
----------------
kcc wrote:
> I wonder if you can reuse functionality from clang/Basic/FileManager.h
> It's rather sad that we need to re-implement such basic stuff here. 
There's a FIXME on `FileManager::removeDotPaths` saying `FIXME: Move this to llvm::sys::path.` so I think now is a perfect time to address that FIXME.


http://reviews.llvm.org/D14356





More information about the llvm-commits mailing list