[PATCH] D14369: [ValueTracking] De-pessimize isImpliedCondition around unsigned compares

[Sanjoy Das via llvm-commits]

sanjoy created this revision.
sanjoy added reviewers: reames, majnemer.
sanjoy added a subscriber: llvm-commits.

Currently `isImpliedCondition` will optimize "I +_nuw C < L ==> I < L"
only if C is positive.  This is an unnecessary restriction -- the
implication holds even if `C` is negative.

http://reviews.llvm.org/D14369

Files:
  lib/Analysis/ValueTracking.cpp
  test/Transforms/InstSimplify/implies.ll

Index: test/Transforms/InstSimplify/implies.ll
===================================================================
--- test/Transforms/InstSimplify/implies.ll
+++ test/Transforms/InstSimplify/implies.ll
@@ -65,7 +65,7 @@
   ret i1 %res
 }
 
-; i +_{nuw} C_{>0} <u L ==> i <u L
+; i +_{nuw} C <u L ==> i <u L
 define i1 @test4(i32 %length.i, i32 %i) {
 ; CHECK-LABEL: @test4
 ; CHECK: ret i1 true
@@ -116,6 +116,17 @@
   ret i1 %res
 }
 
+; i +_{nuw} C <s L ==> i < L, even if C is negative
+define i1 @test9(i32 %length.i, i32 %i) {
+; CHECK-LABEL: @test9(
+; CHECK: ret i1 true
+  %iplus1 = add nuw i32 %i, -100
+  %var29 = icmp ult i32 %i, %length.i
+  %var30 = icmp ult i32 %iplus1, %length.i
+  %res = icmp ule i1 %var30, %var29
+  ret i1 %res
+}
+
 ; X >=(s) Y == X ==> Y (i1 1 becomes -1 for reasoning)
 define i1 @test_sge(i32 %length.i, i32 %i) {
 ; CHECK-LABEL: @test_sge
Index: lib/Analysis/ValueTracking.cpp
===================================================================
--- lib/Analysis/ValueTracking.cpp
+++ lib/Analysis/ValueTracking.cpp
@@ -4109,12 +4109,12 @@
   case CmpInst::ICMP_ULE: {
     ConstantInt *CI;
 
-    // LHS u<  LHS +_{nuw} C   if C > 0
-    // LHS u<= LHS +_{nuw} C   if C >= 0
+    // LHS u<  LHS +_{nuw} C   if C != 0
+    // LHS u<= LHS +_{nuw} C
     if (match(RHS, m_NUWAdd(m_Specific(LHS), m_ConstantInt(CI)))) {
       if (Pred == CmpInst::ICMP_ULT)
-        return CI->getValue().isStrictlyPositive();
-      return !CI->isNegative();
+        return !CI->isZero();
+      return true;
     }
     return false;
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14369.39313.patch
Type: text/x-patch
Size: 1564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151105/b96bbda8/attachment.bin>