[PATCH] D13666: Add an (optional) identification block in the bitcode

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:2848
@@ +2847,3 @@
+  // Write the major.minor.patch version
+  Abbv = new BitCodeAbbrev();
+  Abbv->Add(BitCodeAbbrevOp(bitc::IDENTIFICATION_CODE_VERSION));
----------------
aizatsky wrote:
> The revision that was actually submitted is different at least in this location:
> 
> https://github.com/llvm-mirror/llvm/commit/b738d340fa9958dbefe8d23a4d4659c2255b823a
> 
> The submitted version has a bug and a resulting memory leak.
Fixed in r252110.

The committed diff was significantly different because this last diff was a proposal for another scheme for the versioning (Major/Minor/Patch instead of Epoch), the committed diff is based on the previous diff for this revision.


http://reviews.llvm.org/D13666