[PATCH] D13841: [CMake] Bug 25059 - CMake libllvm.so.$MAJOR.$MINOR shared object name not compatible with ldconfig

[Andrew Wilkins via llvm-commits]

axw added inline comments.

================
Comment at: cmake/modules/AddLLVM.cmake:547
@@ +546,3 @@
+          set_target_properties(${name} PROPERTIES OUTPUT_NAME ${library_name})
+          set_property(TARGET ${name} APPEND_STRING PROPERTY
+            LINK_FLAGS " -Wl,--soname,${CMAKE_SHARED_LIBRARY_PREFIX}${library_name}${CMAKE_SHARED_LIBRARY_SUFFIX}")
----------------
Sorry, I actually meant to delete the comment about APPEND_STRING. I think set_target_properties' LINK_FLAGS is a special case.

Anyway, it turns out you can just delete this. If you don't specify SOVERSION, VERSION or NO_SONAME, CMake automatically set SONAME to the same as the output name.

LGTM with this last change. Thank you.


http://reviews.llvm.org/D13841