[PATCH] D13666: Add an (optional) identification block in the bitcode

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 13:02:53 PST 2015


aizatsky added a subscriber: aizatsky.

================
Comment at: lib/Bitcode/Writer/BitcodeWriter.cpp:2848
@@ +2847,3 @@
+  // Write the major.minor.patch version
+  Abbv = new BitCodeAbbrev();
+  Abbv->Add(BitCodeAbbrevOp(bitc::IDENTIFICATION_CODE_VERSION));
----------------
The revision that was actually submitted is different at least in this location:

https://github.com/llvm-mirror/llvm/commit/b738d340fa9958dbefe8d23a4d4659c2255b823a

The submitted version has a bug and a resulting memory leak.


http://reviews.llvm.org/D13666





More information about the llvm-commits mailing list