[PATCH] D14199: [compiler-rt] [tsan] Unify aarch64 mapping

[Adhemerval Zanella via llvm-commits]

zatrazz added inline comments.

================
Comment at: lib/tsan/rtl/tsan_platform.h:154
@@ +153,3 @@
+
+extern uptr kLoAppMemBeg;
+extern uptr kLoAppMemEnd;
----------------
I declared them in the header because I used the constants in the function definitions at lib/tsan/rtl/tsan_platform_linux.cc.  I can move them to the cc file if it desirable, but I think by removing the definitions will require to hardcode its value on the function definition somehow (and I think current approach in simple than replicate the hexadecimals values in some places).

Also, I use them so to add another VMA (48-bits) would not require much work. Instead of adding now 'vma_39_42' and then moving it to 'vma_39_42_48', the patch will just require to check and add the 48-bits definitions.

================
Comment at: lib/tsan/rtl/tsan_platform.h:170
@@ -148,1 +169,3 @@
+
+#define __TSAN_NOINLINE_FUNCTIONS 1
 #endif
----------------
I will change it.

================
Comment at: lib/tsan/rtl/tsan_platform.h:382
@@ -342,2 +381,3 @@
 void InitializePlatform();
+void InitializePlatformSpecificModules();
 void FlushShadowMemory();
----------------
I will change it (I used 'modules' and 'specific' because I could not came up with a better naming).


http://reviews.llvm.org/D14199