[PATCH] D14340: [DAGCombiner] Improve zextload optimization.

Geoff Berry via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 12:22:40 PST 2015


gberry added inline comments.

================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3020-3022
@@ +3019,5 @@
+
+  // Do not change the width of a volatile load.
+  // Do not generate loads of non-round integer types since these can
+  // be expensive (and would be wrong if the type is not byte sized).
+  if (!LoadN->isVolatile() && LoadedVT.bitsGT(ExtVT) && ExtVT.isRound() &&
----------------
arsenm wrote:
> Should this check TLI,shouldReduceLoadWidth? It maybe should go along with the other tests before the place this is called
That seems like it should be a separate change to me.  The intent of this change is not to change the behavior of visitAND at all.


http://reviews.llvm.org/D14340





More information about the llvm-commits mailing list