[PATCH] D14305: [IR] Add a `data_operand` abstraction

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 11:46:13 PST 2015


sanjoy added inline comments.

================
Comment at: include/llvm/IR/InstrTypes.h:1130
@@ +1129,3 @@
+  bool operandsHaveAttr(Attribute::AttrKind A) const {
+    // Conservative answer:  no operands have any attributes.
+    return false;
----------------
reames wrote:
> Given this, I'm somewhat questioning the need for this entire change.  How horrible would it be to just make each place which tries to visit call site arguments have a check for whether the call has any bundle and then bail?  This sorta feels like unnecessarily generality.  
We will soon have `nocapture` and `readonly` for values in the `"deopt"` operand bundle here.


http://reviews.llvm.org/D14305





More information about the llvm-commits mailing list