[PATCH] D14336: [tsan] Fix the memcpy interceptor to be memmove compatible on OS X

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 08:52:41 PST 2015


dvyukov added a comment.

I suspect there were reasons to call internal_memcpy. For example, if we intercept memcpy from dynamic loader when nothing is initialized yet, REAL(memcpy) is NULL.
We generally try to move in the opposite direction -- the less we call out from runtime, the less problems we have.
Use internal_memmove, it is already implemented.


http://reviews.llvm.org/D14336





More information about the llvm-commits mailing list