[PATCH] D14332: [ARM] Combine CMOV into BFI where possible

[Chad Rosier via llvm-commits]

mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.

LGTM with one request.:  Mind adding a test case where CM has 2 set bits?  With that in place feel free to commit.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:10491
@@ +10490,3 @@
+    V = DAG.getNode(ARMISD::BFI, dl, VT, V, X,
+                    // Confusingly, the operand is an *inverted* mask...
+                    DAG.getConstant(~Mask, dl, VT));
----------------
How about just a single period?

================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:10516
@@ -10417,1 +10515,3 @@
 
+  // BFI is only available on V6T2+
+  if (!Subtarget->isThumb1Only() && Subtarget->hasV6T2Ops()) {
----------------
Please add a period.


http://reviews.llvm.org/D14332