[PATCH] D14331: [X86][AVX512] add comi with Sae

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 06:10:55 PST 2015


delena added inline comments.

================
Comment at: ../llvm/lib/Target/X86/X86ISelLowering.cpp:4002
@@ +4001,3 @@
+  unsigned IntImm = CImm->getZExtValue();
+  switch (IntImm) {
+    default: llvm_unreachable("Invalid floating point condition!");
----------------
(imm & 0x8) >> 3

================
Comment at: ../llvm/lib/Target/X86/X86ISelLowering.cpp:4129
@@ -4086,1 +4128,3 @@
 
+static unsigned TranslateX86ConstCondToX86CC(SDValue &imm) {
+  ConstantSDNode *CImm = dyn_cast<ConstantSDNode>(imm);
----------------
I think the whole function should be something like this:

{ return imm & 0x7; }


http://reviews.llvm.org/D14331





More information about the llvm-commits mailing list