[PATCH] D14322: AVX512 : VMOVSHDUP/VMOVSLDUP implementation.

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 04:12:20 PST 2015


delena added inline comments.

================
Comment at: lib/Target/X86/InstPrinter/X86InstComments.cpp:37
@@ +36,3 @@
+
+static MVT getRegOperandVectorVT(const MCInst *MI, const MVT &ST,
+                                 unsigned OperandIndex = 0) {
----------------
Operand index should be explicit.
The second parameter: MVT ScalarVT

================
Comment at: lib/Target/X86/InstPrinter/X86InstComments.cpp:348
@@ -323,2 +347,3 @@
     DestName = getRegName(MI->getOperand(0).getReg());
-    DecodeMOVSLDUPMask(MVT::v8f32, ShuffleMask);
+    if (MI->getNumOperands() < 6)
+      Src1Name = getRegName(MI->getOperand(1).getReg());
----------------
missing comments


Repository:
  rL LLVM

http://reviews.llvm.org/D14322





More information about the llvm-commits mailing list