[PATCH] D14324: [tsan] Shadow memory setup for OS X

[Dmitry Vyukov via llvm-commits]

dvyukov added a comment.

Please shuffle code differently.
I have 2 concerns here:

1. tsan_rtl.cc is already a bit of trash can, and I don't want it to continue moving in that direction (initially it was meant for abstract state-machine logic only).
2. The distinction between InitializeShadowMemory and InitializeShadowMemoryPlatform is not clear, e.g. what will you put in what function on windows?

So please put the common functions into a new tsan_platform_posix.cc, put definition of CheckAndProtect into tsan_platform.h, call InitializeShadowMemoryPlatform from within InitializeShadowMemory (so that Initialize only calls InitializeShadowMemory, and then it's platform business what it does there).


http://reviews.llvm.org/D14324