[PATCH] D14322: AVX512 : VMOVSHDUP/VMOVSLDUP implementation.

[Elena Demikhovsky via llvm-commits]

delena added inline comments.

================
Comment at: lib/Target/X86/InstPrinter/X86InstComments.cpp:155
@@ -154,1 +154,3 @@
 
+#define CASE_MASK_INS_COMMON(Inst, Suffix, src)  \
+  case X86::V##Inst##Suffix##src:                \
----------------
I propose to add some helper functions, like isZMMReg(), isYMMReg(), isXMMReg(),
it will simplify value type detection in some cases. And may be useful later.

================
Comment at: lib/Target/X86/InstPrinter/X86InstComments.cpp:191
@@ +190,3 @@
+  CASE_MASK_INS_COMMON(MOVSLDUP, Z, rm)
+    HasMemOp = true;        // FALL THROUGH.
+  CASE_MASK_INS_COMMON(MOVSHDUP, Z, rr)
----------------
We can examine the number of operands in order see if the instruction has memory operand.

================
Comment at: lib/Target/X86/InstPrinter/X86InstComments.cpp:225
@@ -155,1 +224,3 @@
+
+
 //===----------------------------------------------------------------------===//
----------------
remove empty line


Repository:
  rL LLVM

http://reviews.llvm.org/D14322